Conversation
It is a high performant alternative to libpcap engine. Only Linux supported. Performance gain can be up to 50% depending on traffic type. Can be enabled using: `--input-raw-engine af_packet`
houndci-bot
reviewed
Jun 26, 2021
| TPacket *afpacket.TPacket | ||
| } | ||
|
|
||
| func newAfpacketHandle(device string, snaplen int, block_size int, num_blocks int, |
Collaborator
There was a problem hiding this comment.
don't use underscores in Go names; func parameter block_size should be blockSize
don't use underscores in Go names; func parameter num_blocks should be numBlocks
| "github.com/google/gopacket/pcap" | ||
| "golang.org/x/net/bpf" | ||
|
|
||
| _ "github.com/google/gopacket/layers" |
Collaborator
There was a problem hiding this comment.
a blank import should be only in a main or test package, or have a comment justifying it
xingren23
referenced
this pull request
in xingren23/goreplay
Sep 4, 2021
It is a high performant alternative to libpcap engine. Only Linux supported. Performance gain can be up to 50% depending on traffic type. Can be enabled using: `--input-raw-engine af_packet`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a high performant alternative to libpcap engine.
Only Linux supported.
Performance gain can be up to 50% depending on traffic type.
Can be enabled using:
--input-raw-engine af_packet