Skip to content

Remove xfail marker on a PEP 649 related test#12609

Merged
Viicos merged 1 commit into
mainfrom
vp/unfail-test
Dec 4, 2025
Merged

Remove xfail marker on a PEP 649 related test#12609
Viicos merged 1 commit into
mainfrom
vp/unfail-test

Conversation

@Viicos

@Viicos Viicos commented Dec 3, 2025

Copy link
Copy Markdown
Member

Change Summary

Thanks to python/cpython#138164 (included in 3.14.1), Python is now able to preserve references when building the forward ref object, and so calling _eval_type() on the individual annotations works as expected.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from davidhewitt December 3, 2025 20:33
@Viicos Viicos added the relnotes-ignore Omit this PR from the release notes. label Dec 3, 2025
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0273cef
Status: ✅  Deploy successful!
Preview URL: https://4da87437.pydantic-docs.pages.dev
Branch Preview URL: https://vp-unfail-test.pydantic-docs.pages.dev

View logs

@codspeed-hq

codspeed-hq Bot commented Dec 3, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #12609 will not alter performance

Comparing vp/unfail-test (0273cef) with main (bc15b36)

Summary

✅ 211 untouched

@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Coverage report

Image Image

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos merged commit 53cb5f8 into main Dec 4, 2025
70 checks passed
@Viicos Viicos deleted the vp/unfail-test branch December 4, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-ignore Omit this PR from the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants