Simplify semantics of assemble_lincomb / fix #1276#1296
Merged
Conversation
Also fixes #1276 by more carefully ensuring that assemble is idempotent.
… of LincombOperator
Codecov Report
|
pmli
approved these changes
Apr 26, 2021
| if op: | ||
| # To avoid infinite recursions, only use the result if at least one of the following | ||
| # is true: | ||
| # - The operator is parametric, so the the result of assemble *must* be a different, |
Member
There was a problem hiding this comment.
Suggested change
| # - The operator is parametric, so the the result of assemble *must* be a different, | |
| # - The operator is parametric, so the result of assemble *must* be a different, |
| # - One of self.operators changed by calling 'assemble' on it. | ||
| # - The result of assemble_lincomb is of a different type than the original operator. | ||
| # - assemble_lincomb could simplify the list of assembled operators, | ||
| # which we define to be the case when the number of operators has ben reduced. |
Member
There was a problem hiding this comment.
Suggested change
| # which we define to be the case when the number of operators has ben reduced. | |
| # which we define to be the case when the number of operators has been reduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1276.