Skip to content

Fixes #1744#1745

Merged
sdrave merged 1 commit into
pymor:mainfrom
peoe:1744-conjugate-param-functionals
Sep 14, 2022
Merged

Fixes #1744#1745
sdrave merged 1 commit into
pymor:mainfrom
peoe:1744-conjugate-param-functionals

Conversation

@peoe

@peoe peoe commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

This pull request should fix issue #1744.

@peoe peoe force-pushed the 1744-conjugate-param-functionals branch from 750f749 to 7266345 Compare September 9, 2022 10:39
@peoe peoe changed the title Proposes a fix to #1744 Fixes #1744 Sep 9, 2022
@codecov

codecov Bot commented Sep 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1745 (7266345) into main (cd7ec2f) will decrease coverage by 5.77%.
The diff coverage is 50.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/pymor/parameters/functionals.py 90.40% <50.00%> (-0.33%) ⬇️
src/pymordemos/neural_networks.py 0.00% <0.00%> (-96.43%) ⬇️
src/pymordemos/fenics_nonlinear.py 0.00% <0.00%> (-96.06%) ⬇️
src/pymor/models/neural_network.py 2.27% <0.00%> (-92.05%) ⬇️
src/pymordemos/neural_networks_fenics.py 0.00% <0.00%> (-91.55%) ⬇️
src/pymordemos/neural_networks_instationary.py 0.00% <0.00%> (-85.82%) ⬇️
src/pymor/reductors/neural_network.py 0.42% <0.00%> (-85.54%) ⬇️
src/pymortests/mpi_run_demo_tests.py 2.12% <0.00%> (-78.73%) ⬇️
src/pymor/discretizers/fenics/cg.py 0.00% <0.00%> (-75.87%) ⬇️
src/pymor/parallel/mpi.py 26.47% <0.00%> (-73.53%) ⬇️
... and 58 more

@sdrave sdrave added the pr:fix Fixes a bug label Sep 14, 2022
@sdrave sdrave added this to the 2022.2 milestone Sep 14, 2022

@sdrave sdrave left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sdrave sdrave enabled auto-merge September 14, 2022 08:45
@sdrave sdrave merged commit 89ac75b into pymor:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants