Repace 'invert_options' by 'solver_options' (second try)#184
Merged
Conversation
- 'options' is removed from OperatorInterface.apply_inverse - 'invert_options' is removed from OperatorInterface - 'solver_options' is added to OperatorInterface If not 'None', solver_options is a dict which can contain the keys 'inverse' and 'jacobian'. The following rules apply: - OperatorInterface.apply_inverse uses the 'inverse' entry of solver_options for solver selection and configuration. If not available, or 'None', defaults are used. - OperatorInterface.jacobian uses the values of the 'jacobian' entry of solver_options as solver_options for the Jacobian operator. If missing, solver_options is set to None. - OperatorInterface.assemlbe returns an assembled operator with the same solver_options. - OperatorInterface.projected and OperatorInterface.restricted return operators with solver_options set to None.
Member
Author
|
After some discussion, we decided that there are too many corner cases where the approach in #183 does not work out very well. As there are relatively few places, where new operators are created, for which appropriate |
Conflicts: src/pymor/algorithms/timestepping.py
Contributor
|
Very nice, thank you! If I remember correctly, we also decided to allow for an 'adjoint_inverse' key in the 'solver_options', just for future reference. The tests currently seem to fail bc. of the newton, which might be related to 45c797f? |
sdrave
added a commit
that referenced
this pull request
Nov 19, 2015
Repace 'invert_options' by 'solver_options'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the following changes:
optionsis removed fromOperatorInterface.apply_inverseinvert_optionsis removed fromOperatorInterfacesolver_optionsis added toOperatorInterfacesolver_optionscan be given to the implict Euler algorithm.If not
None,solver_optionsis a dict which can contain the keys'inverse'and'jacobian'. The following rules apply:OperatorInterface.apply_inverseuses the'inverse'entryof
solver_optionsfor solver selection and configuration.If not available, or
None, defaults are used.OperatorInterface.jacobianuses the values of the'jacobian'entry of
solver_optionsassolver_optionsfor the Jacobianoperator. If missing,
solver_optionsis set toNone.OperatorInterface.assemblereturns an assembled operator withthe same
solver_options.OperatorInterface.projectedandOperatorInterface.restrictedreturn operators with
solver_optionsset toNone.This PR addresses #122.