Skip to content

Add H2 norm preset for TransferFunction#2180

Merged
pmli merged 2 commits into
pymor:mainfrom
peoe:tf-presets
Nov 6, 2023
Merged

Add H2 norm preset for TransferFunction#2180
pmli merged 2 commits into
pymor:mainfrom
peoe:tf-presets

Conversation

@peoe

@peoe peoe commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

Closes #2143. As far as I can tell, TransferFunction currently only supports h2_norm, but additional keys can be added as in LTIModel.

This also touches the second checkbox under the $H_2$ norm section in #391.

@peoe peoe changed the title Add $H_2$ norm preset for TransferFunction Add H2 norm preset for TransferFunction Sep 13, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Mirroring external branch in external_pr_2180

@pmli pmli self-requested a review September 18, 2023 06:03
@pmli pmli added the pr:new-feature Introduces a new feature label Sep 27, 2023
@pmli pmli added this to the 2023.2 milestone Sep 27, 2023

@pmli pmli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @peoe. Do you want to update AUTHORS.md?

@pmli pmli self-assigned this Nov 2, 2023
@pmli pmli enabled auto-merge November 6, 2023 20:35
@pmli pmli added this pull request to the merge queue Nov 6, 2023
Merged via the queue into pymor:main with commit 51ee8dd Nov 6, 2023
@github-actions

github-actions Bot commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Local mirror branch external_pr_2180 deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:new-feature Introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TransferFunction presets

2 participants