Remove space ids#2357
Merged
Merged
Conversation
0c86632 to
6c4f7ab
Compare
Open
HenKlei
approved these changes
Sep 23, 2024
pmli
requested changes
Sep 23, 2024
pmli
left a comment
Member
There was a problem hiding this comment.
Files reduced_model.out and results.out have been added. I guess this was not on purpose. I had similar issues with those files, perhaps they could be added to .gitignore.
6c4f7ab to
4b5ed12
Compare
Member
Author
Ouch. They were actually listed in |
pmli
requested changes
Sep 24, 2024
pmli
left a comment
Member
There was a problem hiding this comment.
Looks good to me, except that DuneXTMatrixOperator documents source_id and range_id.
pmli
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.