[sys-mor] various reductor improvements#661
Merged
Merged
Conversation
- initialize all class attributes in __init__ - merge use_arnoldi into projection - add reductors to non-projection-based methods - various minor improvements
sdrave
reviewed
Mar 27, 2019
sdrave
left a comment
Member
There was a problem hiding this comment.
LGTM. However, I would prefer TFBHIReductor. TF_BHIReductor looks awkward (does PEP8 allow it?)
Member
Author
I agree. (flake8 does not complain.) I'll remove the underscore also from other "BHI" and "IRKA" methods. |
sdrave
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduce_arnoldifromLTI_BHIReductor, mergesuse_arnoldioption withprojection__init__pg_redutora private attributeDoperator inSOBTReductorTFInterpReductortoTF_BHIReductorto fit with other "BHI" reductors