Skip to content

Fixed accumulating include dirs after compile#199

Merged
jaraco merged 1 commit into
pypa:mainfrom
mrbean-bremen:issue3591
Feb 6, 2023
Merged

Fixed accumulating include dirs after compile#199
jaraco merged 1 commit into
pypa:mainfrom
mrbean-bremen:issue3591

Conversation

@mrbean-bremen

@mrbean-bremen mrbean-bremen commented Jan 18, 2023

Copy link
Copy Markdown
Contributor
  • makes a copy of include dir list to avoid increasing the list in subsequent calls of compile
  • fix had been proposed by @mdavidsaver in 3591

The problem has been introduced by this commit, but it may also be problematic besides that: the internal include dir list is returned and can be modified unintentionally by the caller.

Fixes pypa/setuptools#3591 after merged back to setuptools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCompiler self.include_dirs modified during each compile()

2 participants