Move compilers into their own package#295
Merged
Merged
Conversation
1 task
b430f82 to
cdd4c28
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a small step toward exposing the compiler functionality outside of distutils namespace, this PR moves all of the compiler functionality and tests into its own package (
distutils.compilers.C). This arrangement makes it easier to see the boundaries of this functionality and reason about the dependencies (i.e. what imports still reference distutils).This approach keeps compatibility shims so that the compilers and functions and constants are still available in the classic locations.
I'm making this incremental step in order release this concept and make sure it's stable before embarking on removing the distutils dependencies (if that's even possible).
I also took the liberty of using these new namespaces to make the names shorter, less repetetive, and easier to reason about (e.g.
compilers.C.unix.Compilerinstead ofunixccompiler.UnixCCompiler).