Skip to content

Restore public symbols missing after compilers move#337

Merged
jaraco merged 1 commit into
pypa:mainfrom
Avasam:add-back-compiler.compiler_class
Mar 18, 2025
Merged

Restore public symbols missing after compilers move#337
jaraco merged 1 commit into
pypa:mainfrom
Avasam:add-back-compiler.compiler_class

Conversation

@Avasam

@Avasam Avasam commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Closes #336 and closes pypa/setuptools#4876

  • Adds back distutils.ccompiler.compiler_class for backwards compatibility
  • Removes importing the msvc symbol when from distutils._msvccompiler import *

@Avasam Avasam force-pushed the add-back-compiler.compiler_class branch from dd24ead to 17854a1 Compare March 11, 2025 02:18
@Avasam Avasam closed this Mar 11, 2025
@Avasam Avasam reopened this Mar 11, 2025
@jaraco

jaraco commented Mar 16, 2025

Copy link
Copy Markdown
Member

Thanks for this contrib. I don't see where the need for PLAT_SPEC_TO_RUNTIME comes from.

@Avasam

Avasam commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

I simply restored the names that were public in the modules. If you only wanna add PLAT_SPEC_TO_RUNTIME if someone asks for it, I can remove it from this PR.

@jaraco

jaraco commented Mar 17, 2025

Copy link
Copy Markdown
Member

I simply restored the names that were public in the modules. If you only wanna add PLAT_SPEC_TO_RUNTIME if someone asks for it, I can remove it from this PR.

Okay. Yeah, let's remove it. Thanks!

Comment thread newsfragments/336.bugfix.rst Outdated
@Avasam Avasam force-pushed the add-back-compiler.compiler_class branch from 17854a1 to 408274b Compare March 17, 2025 01:48
@jaraco jaraco merged commit 6c0427b into pypa:main Mar 18, 2025
@Avasam Avasam deleted the add-back-compiler.compiler_class branch March 18, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Lost distutils.ccompiler.compiler_class in latest release Lost distutils.ccompiler.compiler_class in latest release

2 participants