Add initial support for license-files#705
Merged
Merged
Conversation
e6ccab1 to
2704faf
Compare
Member
Author
|
@takluyver Would love to get your opinion here. I do plan to continue working on the PEP 639 support afterwards. |
AA-Turner
reviewed
Nov 22, 2024
AA-Turner
reviewed
Nov 22, 2024
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
b771caa to
7fbf608
Compare
This was referenced Nov 24, 2024
takluyver
reviewed
Feb 4, 2025
takluyver
left a comment
Member
There was a problem hiding this comment.
Thanks, I think this basically looks good, but there are a few extra checks that I think should occur on the config.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
license-fileskey inpyproject.toml.https://peps.python.org/pep-0639/#add-license-files-key
https://peps.python.org/pep-0639/#add-license-file-field
This PR only adds the required validation and ensures the license files are properly packaged in the
.dist-info/licensesfolder. It doesn't add theLicense-Filekey to the metadata as that requires full support for metadata version2.4.Work on #692