Added .idea/ to gitignore, to cover cases where people are using a Jetbrains text editor#1497
Conversation
…tbrains text editor.
|
@joeflack4 Thanks for this PR! Always nice when you don't have to think too hard about whether or not to merge something ;) |
|
Sorry to be a contrarian, but I've probably rejected this idea before. It doesn't make sense to update every project's .gitignore for every developer's environment. This preference should be added to each JetBrains developers global ignores (for example, here's mine). I also encourage Python developers to put Python ignores there. In my opinion, .gitignore for a project should include ignores unique to that project (and little more). I won't revert this change. I've stopped trying to keep the ignores trim. Just wanted to share my opinion for perhaps a different perspective. |
|
@jaraco I did consider this, and honestly I'd probably like to reorganize the The reasons I think it's probably not so bad are:
Ideally editors and file systems wouldn't pollute working directories with |
|
Thanks very much for the merge. I didn't expect this fast of a response, and these high quality comments in reply to the humble PR. Thanks! @jaraco Also, I didn't even know about Jetbrains global ignores. Did you mean to have linked this though? If so, I do not see where the example is. Also on other # syntax: glob
.*
!.codecov.yml
!.github/
!.gitignore
!.readthedocs.yml
!.readthedocs.yml
bin
build
dist
docs/build
include
lib
distribute.egg-info
setuptools.egg-info
*.egg
*.py[cod]
*.swp
*~ |
No; |
|
FYI, I cut a release with this change just to do a demo of the release workflow. I wouldn't normally cut a release for a change that doesn't affect the published distribution. |
|
Thanks @jaraco ! I'll use this. |
Summary of changes
Added .idea/ to gitignore, to cover cases where people are using a Jetbrains text editor