Drop use of six.u#1517
Conversation
| dist = Distribution() | ||
| cmd = ei.easy_install(dist) | ||
| tmp_dir = None | ||
| with cmd._tmpdir() as tmp_dir_name: |
There was a problem hiding this comment.
We don't usually test the private interface of these functions directly, it's better to try to hit the relevant code indirectly. _tmpdir seems to have pretty good code coverage already as it's used every time easy_install is called.
There was a problem hiding this comment.
So no tests required?
There was a problem hiding this comment.
Very good instincts to add a test, though.
I suspect there is some way to test this particular functionality by trying to assert that none of the files written into this directory persist when easy_install is done being used, but frankly we're trying to get rid of easy_install anyway, so it's probably not worth spending much time working out clever tests for it.
There was a problem hiding this comment.
So no tests required?
Correct, you don't need to add a test for this.
|
I have dropped the unnecessary test, this can be merged when CI passes. |
|
@zapstar Thanks for your PR, really quick on the draw! Once the CI passes myself or one of the other maintainers will merge it. Feel free to check out other issues in the help wanted label if you want something with a bit more meat to dig into! |
|
@benoit-pierre Did you want to merge this? I don't know what you need to see with respect to the rolling builds, so I don't want you to miss it if I do the merge. |
|
It's unrelated to rolling builds support, but yes, assuming setuptools suffered from the same bug, let's see how many builds are triggered by the merge! |
Summary of changes
Drop use of six.u in the code. Trivial changes, I thought you folks had more than one occurrence of six.u here.
Closes #1516
Pull Request Checklist