Skip to content

Fixed a bug that easy install incorrectly parsed Python 3.10 version string#2953

Merged
jaraco merged 2 commits into
pypa:mainfrom
liuzhe-lz:main
Jan 8, 2022
Merged

Fixed a bug that easy install incorrectly parsed Python 3.10 version string#2953
jaraco merged 2 commits into
pypa:mainfrom
liuzhe-lz:main

Conversation

@liuzhe-lz

@liuzhe-lz liuzhe-lz commented Dec 22, 2021

Copy link
Copy Markdown

Summary of changes

Fixed a bug that easy install incorrectly parsed Python 3.10 version string.

Pull Request Checklist

@liuzhe-lz liuzhe-lz changed the title fix version parsing Fixed a bug that easy install incorrectly parsed Python 3.10 version string Dec 22, 2021
@jaraco

jaraco commented Jan 6, 2022

Copy link
Copy Markdown
Member

Looks like this bug was reported in #3001.

Can you add a test?

@abravalheri abravalheri linked an issue Jan 6, 2022 that may be closed by this pull request
1 task
@liuzhe-lz

liuzhe-lz commented Jan 7, 2022

Copy link
Copy Markdown
Author

Looks like this bug was reported in #3001.

Can you add a test?

Sorry I don't have time for now.
Maybe you can help add one. Or I can do it sometime next week.

@abravalheri

abravalheri commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

As the existing tests are not running properly, I think the best here would be an update... So here it goes:

@Mergifyio update

@mergify

mergify Bot commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

update

✅ Branch has been successfully updated

@abravalheri

Copy link
Copy Markdown
Contributor

Hi @liuzhe-lz, @jaraco I added some tests to the proposed fix. Please feel free to remove it, change or add any other tests.

(I also reordered a bit the commits, because I wanted to see the test failing before the fix is applied and study how to better represent the situation in #3001).


Notes:

I noticed the stdlib version of distutils sometimes create a path that contains a literal string 'None', which seems to be a bug already solved in the vendored version.

Another thing that I noticed is that for Windows 3.10, there might be a ValueError: invalid variable 'py_version_nodot_plat', which I guess is already solved by pypa/distutils@1560a1f and will be eventually pulled into setuptools.

@jaraco jaraco merged commit 9f37366 into pypa:main Jan 8, 2022
@jaraco

jaraco commented Jan 8, 2022

Copy link
Copy Markdown
Member

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] setup installs user egg links to python3.1 site under Python 3.10

3 participants