Restore pbr compatibility#4980
Merged
Merged
Conversation
intelfx
added a commit
to intelfx/kvmd
that referenced
this pull request
May 16, 2026
Overriding entrypoint templates via monkey-patching ScriptWriter is nonfunctional since at least setuptools v75.3.4 (pypa/setuptools#4963 and subsequently pypa/setuptools#4980 which restored the class under the old unused name, masking the problem). Even then, it would have only worked under legacy non-wheel installation path, which was not happening anyway. Current entrypoint templates synthesized by either pip or installer are not zero-overhead (str.remove_suffix() or re.sub() respectively), but the overhead (≈1ms) is negligible compared to the original setuptools' template that used importlib. This overhead is considered acceptable and not worth the hassle of coming up with a new method to override the entrypoint script generation.
intelfx
added a commit
to intelfx/kvmd
that referenced
this pull request
May 16, 2026
Overriding entrypoint templates via monkey-patching ScriptWriter is nonfunctional since at least setuptools v75.3.4 (pypa/setuptools#4963 and subsequently pypa/setuptools#4980 which restored the class under the old unused name, masking the problem). Even then, it would have only worked under legacy non-wheel installation path, which was not happening anyway. Current entrypoint templates synthesized by either pip or installer are not zero-overhead (str.remove_suffix() or re.sub() respectively), but the overhead (≈1ms) is negligible compared to the original setuptools' template that used importlib. This overhead is considered acceptable and not worth the hassle of coming up with a new method to override the entrypoint script generation.
mdevaev
pushed a commit
to pikvm/kvmd
that referenced
this pull request
May 16, 2026
Overriding entrypoint templates via monkey-patching ScriptWriter is nonfunctional since at least setuptools v75.3.4 (pypa/setuptools#4963 and subsequently pypa/setuptools#4980 which restored the class under the old unused name, masking the problem). Even then, it would have only worked under legacy non-wheel installation path, which was not happening anyway. Current entrypoint templates synthesized by either pip or installer are not zero-overhead (str.remove_suffix() or re.sub() respectively), but the overhead (≈1ms) is negligible compared to the original setuptools' template that used importlib. This overhead is considered acceptable and not worth the hassle of coming up with a new method to override the entrypoint script generation.
floydelcy
pushed a commit
to floydelcy/kvmd
that referenced
this pull request
May 17, 2026
Overriding entrypoint templates via monkey-patching ScriptWriter is nonfunctional since at least setuptools v75.3.4 (pypa/setuptools#4963 and subsequently pypa/setuptools#4980 which restored the class under the old unused name, masking the problem). Even then, it would have only worked under legacy non-wheel installation path, which was not happening anyway. Current entrypoint templates synthesized by either pip or installer are not zero-overhead (str.remove_suffix() or re.sub() respectively), but the overhead (≈1ms) is negligible compared to the original setuptools' template that used importlib. This overhead is considered acceptable and not worth the hassle of coming up with a new method to override the entrypoint script generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #4976
Pull Request Checklist
newsfragments/.(See documentation for details)