Cache of AST tree by module path#153
Merged
Merged
Conversation
The dependency graph of a large Python app can be quite a mess. Previously, we were regenerating the AST of files many times, as they were imported by different modules. Adding a simple LRU cache [path -> AST tree] sped up pyt on one of my code bases by 5x. We currently only mutate newly created artificial nodes, so we can store one copy of each module's AST and expect it to be static. We can make it even faster by setting maxsize=None, so there is no eviction logic, but for now I think it's already an improvement. An alternative could be to rewrite the code which deals with imports.
Collaborator
|
You're the greatest! 💯 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency graph of a large Python app can be quite a mess.
Previously, we were regenerating the AST of files many times, as they were
imported by different modules.
Adding a simple LRU cache [path -> AST tree] sped up pyt on one of my
code bases by 5x.
We currently only mutate newly created artificial nodes, so we can store
one copy of each module's AST and expect it to be static.
We can make it even faster by setting
maxsize=None, so there is no evictionlogic, but for now I think it's already an improvement.
An alternative could be to rewrite the code which deals with imports.