Skip to content

Try testing on macos#2266

Merged
Bibo-Joshi merged 4 commits into
masterfrom
test-macos
Dec 30, 2020
Merged

Try testing on macos#2266
Bibo-Joshi merged 4 commits into
masterfrom
test-macos

Conversation

@Bibo-Joshi

@Bibo-Joshi Bibo-Joshi commented Dec 23, 2020

Copy link
Copy Markdown
Member

No description provided.

@Bibo-Joshi Bibo-Joshi added the ⚙️ tests affected functionality: tests label Dec 23, 2020
@Bibo-Joshi

Bibo-Joshi commented Dec 23, 2020

Copy link
Copy Markdown
Member Author
  • timing seems to be instable on macOS. we skip JobQueue tests on windows, should do that here, too. Maybe even for the ConversationHandler timeout thingies
  • For the last three tests, the game picture is wrong and the bots don't have rights to expor the chat invite link of the corresponding group. Need to check which bots that are and change that

@Bibo-Joshi

Bibo-Joshi commented Dec 23, 2020

Copy link
Copy Markdown
Member Author

Test failures seem to be down to the usual stuff. Tried to make them a bit more stable by xfailing all TimedOut errors and making the sleeps in the ConversationHandler-timeout tests a bit more generous.

@Poolitzer

Poolitzer commented Dec 30, 2020

Copy link
Copy Markdown
Member

I mean its still failing but also on windows so

@Bibo-Joshi Bibo-Joshi merged commit 2788191 into master Dec 30, 2020
@Bibo-Joshi Bibo-Joshi deleted the test-macos branch December 30, 2020 14:39
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

⚙️ tests affected functionality: tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bibo-Joshi @Poolitzer