API 6.6#3584
Merged
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Member
|
@marcosdodo please stop spamming, if you continue to do so, you'll be banned |
Bibo-Joshi
commented
Mar 10, 2023
I had implemented the renaming for `StickerSet only`
other tests are probably failing not due to me having changed something...
Bibo-Joshi
commented
Mar 11, 2023
* add aliases to support calls to old methods * issue deprecation warning if an old method is called * WEIRD ERROR in `test_sticker_set_to_dict()` (see my TODO note there)
* add aliases to support calls to old methods * issue deprecation warning if an old method is called * WEIRD ERROR in `test_sticker_set_to_dict()` (see my TODO note there)
Bibo-Joshi
commented
Mar 21, 2023
the method will be removed anyway, no need to add new parameter to it.
the tests were passing because Bot API still supports the old method
Bibo-Joshi
commented
Mar 22, 2023
harshil21
requested changes
Mar 22, 2023
harshil21
left a comment
Member
There was a problem hiding this comment.
phew! Huge update with lots of changes (mostly boilerplate 😞)..
I wonder if we could've gotten away with the renaming by just overriding __(set/get)attr__ in TelegramObject to detect the usage of deprecated parameters
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
This reverts commit b2cd7c2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__sToDo
InputStickermust be tested with local mode @harshil21InputSticker- Toattach://or notatttach://tdlib/telegram-bot-api#375 : Double check ifInputStickershould be uploaded viaattach://If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__acceptsapi_kwargsas kw-onlyAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesMessage.effective_attachmentConversationHandler_extbot.pybot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION_INFOtg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message