Auto-Update Changed Version in Other Files After Dependabot PRs#3716
Merged
Conversation
harshil21
reviewed
May 30, 2023
harshil21
left a comment
Member
There was a problem hiding this comment.
wow nice! Can't we tell it which files to look for though, so error rate can become 0%
Member
Author
|
That was also my inital thought, but that might lead to false negatives. As those can't be seen in a PR diff, I decided that false positives might be the better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new workflow automatically copies versions changed by depandabot to the pre-commit config, the readme and any other file where the version might appear. It's a mit naive, b/c it really just searches for exact matches of the version number, but I guess the cases were we have that exact version number appear elsewhere in the repo are seldom enough. Plus, we can review.
Live examples of this workflow can be seen at https://github.com/Bibo-Joshi/actions-tests/pulls (where you can also see that I got this working almost immediately 🫠)