-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Support specifying values for resources in regrtests #143553
Copy link
Copy link
Closed
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixes3.15pre-release feature fixes, bugs and security fixespre-release feature fixes, bugs and security fixestestsTests in the Lib/test dirTests in the Lib/test dirtype-featureA feature request or enhancementA feature request or enhancement
Description
Metadata
Metadata
Assignees
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixes3.15pre-release feature fixes, bugs and security fixespre-release feature fixes, bugs and security fixestestsTests in the Lib/test dirTests in the Lib/test dirtype-featureA feature request or enhancementA feature request or enhancement
Fields
Give feedbackNo fields configured for issues without a type.
Feature or enhancement
Currently, resources are binary -- they are either enabled or disabled. But sometimes it is useful to enable them partially or to specify a parameter for it. For example, recently added
test_xpickle(#75572) takes more than 2 minutes on fast machine for each available Python version, so it is disabled by default and requires the extraxpickleresource. It would be handy to be able to run it only for the specified Python version, e.g.-u xpickle=2.7would run it with Python 2.7.This feature can also be used in #65784.
This feature the big-memory tests can be implemented as yet one parametrised extra resource. E.g.
-u bigmem=16Ginstead of-M 16G.This feature somewhere intersects with #108828 which I plan to extend to support values too.
There is a question whether we should support comma in values. I.e. whether
-u foo=bar,bazshould be interpreted as one resourcefoowith valuebar,bazor two resourcesfooandbaz, the former with valuebar. For now I choose the latter option, as slightly simpler to implement, but this can be reconsidered in future. It will be a breaking change, but this is an internal API.Linked PRs