build_ext in a venv on Windows assumes pyconfig.h in sys.exec_prefix + '\PC'

[sbt]

BPO	15367
Nosy	@vsajip
Files	build_ext.patch build_ext.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-07-16.17:30:21.146>
created_at = <Date 2012-07-16.11:46:40.508>
labels = ['type-bug']
title = "build_ext in a venv on Windows assumes pyconfig.h in sys.exec_prefix + '\\PC'"
updated_at = <Date 2012-07-16.17:30:21.144>
user = 'https://bugs.python.org/sbt'

bugs.python.org fields:

activity = <Date 2012-07-16.17:30:21.144>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2012-07-16.17:30:21.146>
closer = 'python-dev'
components = []
creation = <Date 2012-07-16.11:46:40.508>
creator = 'sbt'
dependencies = []
files = ['26395', '26400']
hgrepos = []
issue_num = 15367
keywords = ['patch']
message_count = 4.0
messages = ['165590', '165593', '165625', '165643']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'python-dev', 'sbt']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15367'
versions = ['Python 3.3']

[sbt]

On Windows I can't use a source build of Python to create a venv which will compile C extensions because pyconfig.h cannot be found. For example

running build
running build_ext
building 'demo' extension
creating build
creating build\\temp.win32-3.3
creating build\\temp.win32-3.3\\Release
c:\\Program Files (x86)\\Microsoft Visual Studio 10.0\\VC\\BIN\\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -IC:\\Repos\\cpython\\include -IC:\\Users\\oudkerk\\myenv\\PC /Tcdemo.c /Fobuild\\temp.win32-3.3\\Release\\demo.obj

demo.c
C:\Repos\cpython\include\Python.h(8) : fatal error C1083: Cannot open include file: 'pyconfig.h': No such file or directory
error: command '"c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\cl.exe"' failed with exit status 2

The problem seems to be with the following line in distutils/command/build_ext.py:

            self.include_dirs.append(os.path.join(sys.exec_prefix, 'PC'))

Inside a venv, sys.exec_prefix is the venv directory.

[sbt]

The attached patch works for me.

[sbt]

Updated patch which does not fail test_distutils.

[python-dev]

New changeset a970054a93fb by Vinay Sajip in branch 'default':
Closes bpo-15367: Corrected computation of include locations for source builds on Windows. Thanks to Richard Oudkerk for the bug report and patch.
http://hg.python.org/cpython/rev/a970054a93fb