Azure Pipelines currently failing

[gvanrossum]

BPO	45893
Nosy	@gvanrossum, @vstinner, @tiran, @zooba, @miss-islington
PRs	bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29761 [3.10] bpo-45893: Add missing extern C to initconfig.h (GH-29761) #29765

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2021-11-24.22:00:12.126>
created_at = <Date 2021-11-24.18:50:21.265>
labels = ['easy', 'build', '3.10', '3.11']
title = 'Azure Pipelines currently failing'
updated_at = <Date 2021-11-24.22:00:12.126>
user = 'https://github.com/gvanrossum'

bugs.python.org fields:

activity = <Date 2021-11-24.22:00:12.126>
actor = 'christian.heimes'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2021-11-24.22:00:12.126>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2021-11-24.18:50:21.265>
creator = 'gvanrossum'
dependencies = []
files = []
hgrepos = []
issue_num = 45893
keywords = ['patch', 'easy (C)']
message_count = 8.0
messages = ['406945', '406946', '406947', '406950', '406956', '406963', '406965', '406966']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'vstinner', 'christian.heimes', 'steve.dower', 'miss-islington']
pr_nums = ['29761', '29765']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue45893'
versions = ['Python 3.10', 'Python 3.11']

[gvanrossum]

E.g. https://dev.azure.com/Python/cpython/_build/results?buildId=92084&view=results

[zooba]

Seems we lost the C++ handling in Include/cpython/initconfig.h:

#ifdef __cplusplus
extern "C" {
#endif

<full body of file>

#ifdef __cplusplus
}
#endif

[zooba]

Also, we should define $env:IncludeUWP="true" in the Windows PR tests. That will build extra binaries every time (that we ship in the Windows Store) and would catch this issue earlier.

[gvanrossum]

Christian thinks that a PR by Victor broke this (GH-29488 / bpo-39026)

[tiran]

New changeset f4afc53 by Christian Heimes in branch 'main':
bpo-45893: Add missing extern C to initconfig.h (GH-29761)
f4afc53

[vstinner]

Seems we lost the C++ handling in Include/cpython/initconfig.h

I was never in initconfig.h since the PEP-587 (PyConfig C API) was implemented. I'm not sure why the build *started* to fail on Windows.

Thanks for fixing the issue ;-)