gh-103384: Generalize the regex pattern BaseConfigurator.INDEX_PATTERN to allow spaces and non-alphanumeric characters in keys.

[dhuadaar]

The issue described a broken regex pattern in the logging module.
Fixed the regex and added tests for the same.

• Issue: logging.config cfg protocol rejects non-alphanumeric names, contrary to the documentation #103384

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[ghost]

All commit authors signed the Contributor License Agreement.

[tomasr8]

I think a test with some special characters would also be useful :)

[dhuadaar]

I think a test with some special characters would also be useful :)

Makes sense.

Thanks for the suggestions. I will add some of those combinations.

[tomasr8]

I'd also add tests for some edge cases like the empty string (if we want to allow that) and multiple nesting levels e.g. [x][y] or even [x].y[z] to make sure the regex is working as expected.

[dhuadaar]

I'd also add tests for some edge cases like the empty string (if we want to allow that) and multiple nesting levels e.g. [x][y] or even [x].y[z] to make sure the regex is working as expected.

I have added a new nested dictionary to the existing template we use in the test. Added new assertions specifically for the nested cases.

Do you suggest making the cases like the following to the part of the new key added?

'nest2': ['k', ['l', 'm'], 'n'],

Update: Added this anyways.

[vsajip]

Thanks for the PR!

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[dhuadaar]

@vsajip

I have made the requested changes; please review again.

[bedevere-bot]

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

[dhuadaar]

@vsajip
Could you review this PR? I have made the changes requested.

[vsajip]

Sorry I've not had time to look at this. Hope to get to it soon.

[erlend-aasland]

I'll leave it for the code owner @vsajip to land this :) Thanks for your contribution, @dhuadaar!

[erlend-aasland]

Should this be backported?

[vsajip]

Perhaps - it's arguable whether it's an enhancement or could have been considered a documentation bug.

[erlend-aasland]

Ok; if no backport is needed, we should close the linked issue.