gh-106905: Use separate structs to track recursion depth in each PyAST_mod2obj call.#113035
Merged
Conversation
…on depths in PyAST_mod2obj.
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Wait, so ast_state is a global state? Ah, now I see the mistake.
serhiy-storchaka
approved these changes
Dec 13, 2023
|
Thanks @yilei for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @yilei and @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @yilei and @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Dec 25, 2023
… in each PyAST_mod2obj call. (pythonGH-113035) (cherry picked from commit 48c4973) Co-authored-by: Yilei Yang <yileiyang@google.com> Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
|
GH-113472 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 25, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Dec 25, 2023
…n depth in each PyAST_mod2obj call. (pythonGH-113035) (pythonGH-113472) (cherry picked from commit 48c4973) (cherry picked from commit d58a5f4) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Yilei Yang <yileiyang@google.com> Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…h PyAST_mod2obj call. (pythonGH-113035) Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
This was referenced Jan 4, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…h PyAST_mod2obj call. (pythonGH-113035) Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…h PyAST_mod2obj call. (pythonGH-113035) Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…h PyAST_mod2obj call. (pythonGH-113035) Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a race condition in
PyAST_mod2objwhen the GIL could be released due to GC (on Python 3.11).This should fix #106905.