gh-115596: Fix ProgramPriorityTests in test_os permanently changing the process priority#115610
Merged
serhiy-storchaka merged 6 commits intoFeb 17, 2024
Merged
Conversation
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
When the test fails, we only see something like:
subprocess.CalledProcessError: Command '['/home/serhiy/py/cpython/python', '-c', 'if 1:\n import os\n os.setpriority(os.PRIO_PROCESS, os.getpid(), 0 + 1)\n print(os.getpriority(os.PRIO_PROCESS, os.getpid()))\n ']' returned non-zero exit status 1.
Which does not give any information about the cause of the failure. You can use assert_python_ok() which shows the stdout and the stderr of the failed process.
serhiy-storchaka
approved these changes
Feb 17, 2024
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM.
Pure test PRs usually do not need a NEWS entry, but this bug potentially had a large scope.
|
Thanks @brianschubert for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…ging the process priority (pythonGH-115610) (cherry picked from commit 90dd653) Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
|
GH-115616 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…ging the process priority (pythonGH-115610) (cherry picked from commit 90dd653) Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
|
GH-115617 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…ging the process priority (pythonGH-115610)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ging the process priority (pythonGH-115610)
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
…ging the process priority (pythonGH-115610)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115596
Runs the priority setting logic from
ProgramPriorityTests.test_set_get_priorityin a subprocess to prevent the priority change from taking permanent effect.