Skip to content

gh-109120: Fix handle of incorrect star expressions#117444

Merged
pablogsal merged 5 commits into
python:mainfrom
grigoriev-semyon:main
Apr 2, 2024
Merged

gh-109120: Fix handle of incorrect star expressions#117444
pablogsal merged 5 commits into
python:mainfrom
grigoriev-semyon:main

Conversation

@grigoriev-semyon

@grigoriev-semyon grigoriev-semyon commented Apr 2, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Apr 2, 2024
Closed
@pablogsal pablogsal added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Apr 2, 2024
@pablogsal

pablogsal commented Apr 2, 2024

Copy link
Copy Markdown
Member

LGTM

@pablogsal pablogsal merged commit c97d3af into python:main Apr 2, 2024
@miss-islington-app

miss-islington-app Bot commented Apr 2, 2024

Copy link
Copy Markdown

Thanks @grigoriev-semyon for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Apr 2, 2024

Copy link
Copy Markdown

Sorry, @grigoriev-semyon and @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c97d3af2391e62ef456ef2365d48ab9b8cdbe27b 3.12

@miss-islington-app

miss-islington-app Bot commented Apr 2, 2024

Copy link
Copy Markdown

Sorry, @grigoriev-semyon and @pablogsal, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c97d3af2391e62ef456ef2365d48ab9b8cdbe27b 3.11

@pablogsal

pablogsal commented Apr 2, 2024

Copy link
Copy Markdown
Member

@grigoriev-semyon Thanks for the PR! Can you work in the backports using cherry_picker as per #117444 (comment)?

@grigoriev-semyon

grigoriev-semyon commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

@grigoriev-semyon Thanks for the PR! Can you work in the backports using cherry_picker as per #117444 (comment)?

ofc :)

@grigoriev-semyon

grigoriev-semyon commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@grigoriev-semyon Thanks for the PR! Can you work in the backports using cherry_picker as per #117444 (comment)?

is it ok if I make regen-pegen in backport PR? There is some conflicts in parser.c

@lysnikolaou

lysnikolaou commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

is it ok if I make regen-pegen in backport PR? There is some conflicts in parser.c

That's necessary, yes. Fix any conflicts in python.gram and then re-run make regen-pegen.

grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this pull request Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
53adcd8 
…ssions (python#117444)

(cherry picked from commit c97d3af)
grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this pull request Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
ebdd29f 
…ssions (python#117444)

(cherry picked from commit c97d3af)
@grigoriev-semyon grigoriev-semyon mentioned this pull request Apr 2, 2024
Merged
@bedevere-app

bedevere-app Bot commented Apr 2, 2024

Copy link
Copy Markdown

GH-117464 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Apr 2, 2024
@grigoriev-semyon grigoriev-semyon mentioned this pull request Apr 2, 2024
Closed
grigoriev-semyon added a commit to grigoriev-semyon/cpython that referenced this pull request Apr 2, 2024
@grigoriev-semyon
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
87202f0 
…ssions (python#117444)

(cherry picked from commit c97d3af)
@grigoriev-semyon grigoriev-semyon mentioned this pull request Apr 2, 2024
Merged
@bedevere-app

bedevere-app Bot commented Apr 2, 2024

Copy link
Copy Markdown

GH-117465 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 2, 2024
pablogsal pushed a commit that referenced this pull request Apr 3, 2024
@grigoriev-semyon
[3.11] gh-109120: Fix syntax error in handlinh of incorrect star expr…
3bc0d2b 
…essions… (#117464)

gh-109120: Fix syntax error in handlinh of incorrect star expressions (#117444)

(cherry picked from commit c97d3af)
terryjreedy pushed a commit that referenced this pull request Apr 4, 2024
@grigoriev-semyon
[3.12] gh-109120: Fix syntax error in handlinh of incorrect star expr…
a49426a 
…essions… (#117465)

gh-109120: Fix syntax error in handlinh of incorrect star expressions (#117444)

(cherry picked from commit c97d3af)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@grigoriev-semyon @diegorusso
pythongh-109120: Fix syntax error in handlinh of incorrect star expre…
a08eb34 
…ssions (python#117444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

incorrect SyntaxError

3 participants

@grigoriev-semyon @pablogsal @lysnikolaou