Skip to content

gh-123340: Show string value of IS_OP oparg in dis#123348

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-123340
Aug 26, 2024
Merged

gh-123340: Show string value of IS_OP oparg in dis#123348
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-123340

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 26, 2024

Copy link
Copy Markdown
Member

After:

» echo 'a is not b' | ./python.exe -m dis
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              IS_OP                    1 (is not)
              POP_TOP
              RETURN_CONST             0 (None)

and

» echo 'a is b' | ./python.exe -m dis    
  0           RESUME                   0

  1           LOAD_NAME                0 (a)
              LOAD_NAME                1 (b)
              IS_OP                    0 (is)
              POP_TOP
              RETURN_CONST             0 (None)

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick.

Comment thread Misc/NEWS.d/next/Library/2024-08-26-19-36-00.gh-issue-123340.mQKI1H.rst Outdated
@sobolevn sobolevn merged commit 1eed0f9 into python:main Aug 26, 2024
@sobolevn

Copy link
Copy Markdown
Member Author

Thank you both for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants