Skip to content

Revert "gh-123974: Fix time.get_clock_info() on NetBSD (#123975)"#124115

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:revert-gh-123974
Sep 18, 2024
Merged

Revert "gh-123974: Fix time.get_clock_info() on NetBSD (#123975)"#124115
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:revert-gh-123974

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 16, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit b1d6f8a.

We should remove time.thread_time() on NetBSD instead.

@bedevere-app bedevere-app Bot mentioned this pull request Sep 16, 2024
Closed
@vstinner

vstinner commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Instead of a revert alone, can we do a PR which does a revert + disable the clock on NetBSD?

@vstinner

vstinner commented Sep 16, 2024

Copy link
Copy Markdown
Member

Oh, you did it in #124116 in fact.

@serhiy-storchaka

serhiy-storchaka commented Sep 18, 2024

Copy link
Copy Markdown
Member Author

It is better to separate these changes to make backporting to 3.13 easier.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Sep 18, 2024
@serhiy-storchaka serhiy-storchaka merged commit 79a7410 into python:main Sep 18, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the revert-gh-123974 branch September 18, 2024 06:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
@serhiy-storchaka @miss-islington
Revert "pythongh-123974: Fix time.get_clock_info() on NetBSD (pythonG…
8dd7695 
…H-123975)" (pythonGH-124115)

This reverts commit b1d6f8a.
(cherry picked from commit 79a7410)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

GH-124200 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 18, 2024
serhiy-storchaka added a commit that referenced this pull request Sep 18, 2024
@miss-islington @serhiy-storchaka
[3.12] Revert "gh-123974: Fix time.get_clock_info() on NetBSD (GH-123975
708173c 
)" (GH-124115) (GH-124200)

This reverts commit b1d6f8a.
(cherry picked from commit 79a7410)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@zware zware mentioned this pull request Sep 18, 2024
Merged
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@serhiy-storchaka @savannahostrowski
Revert "pythongh-123974: Fix time.get_clock_info() on NetBSD (python#…
4e65bba 
…123975)" (pythonGH-124115)

This reverts commit b1d6f8a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @vstinner