gh-124127: Make Py_REFCNT() opaque in limited C API 3.14#124128
Merged
Conversation
Member
Author
Member
Author
Member
Author
|
I plan to merge this change at the end of the week, unless someone wants to review it or has concerns about it. |
encukou
approved these changes
Sep 23, 2024
encukou
left a comment
Member
There was a problem hiding this comment.
+1, with a nitpick on the implementation:
| } | ||
| #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 < 0x030b0000 | ||
| # define Py_REFCNT(ob) Py_REFCNT(_PyObject_CAST(ob)) | ||
| #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 < 0x030b0000 |
Member
There was a problem hiding this comment.
This #if is now redundant, right?
Member
Author
There was a problem hiding this comment.
It's still needed. (Correct me if I'm wrong.)
Member
Author
|
Merged, thanks for reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--124128.org.readthedocs.build/