Skip to content

gh-124457: Remove coverity from CPython repo#124460

Merged
Mariatta merged 1 commit into
python:mainfrom
Mariatta:remove-coverity
Sep 27, 2024
Merged

gh-124457: Remove coverity from CPython repo#124460
Mariatta merged 1 commit into
python:mainfrom
Mariatta:remove-coverity

Conversation

@Mariatta

@Mariatta Mariatta commented Sep 24, 2024

Copy link
Copy Markdown
Member

Remove coverity from CPython Repo.

There are still some mentions about coverity in the history and changelog for v 2.5. I kept those in there.

@@ -0,0 +1,2 @@
Remove coverity scan from the CPython repo. It has not been used since 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if a Misc News entry is needed, and also I wasn't sure which section should it be.
I chose the "Documentation" section here.

@vstinner

Copy link
Copy Markdown
Member

Please keep it. We are using Coverity at Red Hat. cc @stratakis

@stratakis

Copy link
Copy Markdown
Contributor

While we use coverity at Red Hat, it's usually done on specific time frames using OpenScanHub. And we don't utilize the coverity scan model file. So overall I believe the removal is fine. Maybe in the future a nice project would be to introduce coverity scanning through either some service, the buildbots or github actions.

@vstinner

Copy link
Copy Markdown
Member

And we don't utilize the coverity scan model file.

Oh, I didn't know that.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's remove it. It's easy to add it again if someone decides to use it again.

@AA-Turner AA-Turner changed the title gh-124457: Remove coverity from CPython repo. gh-124457: Remove coverity from CPython repo Sep 26, 2024
@Mariatta Mariatta merged commit 6cba6e1 into python:main Sep 27, 2024
@Mariatta Mariatta deleted the remove-coverity branch September 27, 2024 20:42
@Mariatta

Copy link
Copy Markdown
Member Author

Do I need to backport this?

@Mariatta

Copy link
Copy Markdown
Member Author

And thanks for the reviews!

@vstinner

Copy link
Copy Markdown
Member

Do I need to backport this?

I don't think so.

@Mariatta

Copy link
Copy Markdown
Member Author

Thanks, in this case I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants