gh-124653: relax (again) detection of queue API for logging handlers

[picnixz]

NOw we really have a minmal inteface, namely put_nowait and get. More than that is not needed for the default handlers and listeners.

I think, we had a misunderstanding between what the docs told (namely a queue API) and what we expected at runtime. SimpleQueue is not the compatible with "queue.Queue" since it lacks some methods and neither is multiprocessing.SimpleQueue would never work since it does not even have the put_nowait method (so even before my PRs, this would just break at runtime due to a missing interface).

So it is correct to raise if the queue interface is multiprocessing.SimpleQueue.

• Issue: Python 3.12+ breaks backwards compatibility for logging QueueHandler with queue.SimpleQueue #124653

---

📚 Documentation preview 📚: https://cpython-previews--124897.org.readthedocs.build/

[picnixz]

cc @YvesDup @spacemanspiff2007

[picnixz]

This entire issue makes me wonder whether multiprocessing.SimpleQueue should have a fake put_nowait method or not...

[YvesDup]

This entire issue makes me wonder whether multiprocessing.SimpleQueue should have a fake put_nowait method or not..

If it is necessary to use a multiprocessing.SimpleQueue in logging.QueueHandler, I suggest inheriting from this class and adding a put_nowait method to be consistant with the minimum queue interface.

Updated: perharps adding this case would be nice ?

[picnixz]

Updated: perharps adding this case would be nice ?

I didn't add it because I think it's a bit straightforward. If we add such method in the future to the base class, the test will detect that the class is no longer deemed invalid and if we do not, then the case is already covered by the minimal interface (I think this should be enough).

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @picnixz for commit c1d1f16 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[picnixz]

So we only have a single build bot failure which we already know the reason for. I think this issue will not haunt me again :D (just waiting for @vsajip's green light).

[vsajip]

Thank you for this PR!

[picnixz]

@vsajip friendly ping in case you forgot to merge after approving the PR :')

[miss-islington-app]

Thanks @picnixz for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

[bedevere-app]

GH-125059 is a backport of this pull request to the 3.13 branch.

[bedevere-app]

GH-125060 is a backport of this pull request to the 3.12 branch.

[picnixz]

Huh... I think I forgot to update the JIT ignored files... I hope the test won't make the JIT fail.

[picnixz]

Seems the JIT is fine.