Skip to content

gh-126223: Propagate unicode errors in _interpreters.create()#126224

Merged
sobolevn merged 11 commits into
python:mainfrom
ZeroIntensity:gh-126223
Oct 31, 2024
Merged

gh-126223: Propagate unicode errors in _interpreters.create()#126224
sobolevn merged 11 commits into
python:mainfrom
ZeroIntensity:gh-126223

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Oct 31, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Oct 31, 2024
Closed
@ZeroIntensity ZeroIntensity added the needs backport to 3.13 bugs and security fixes label Oct 31, 2024
sobolevn
sobolevn reviewed Oct 31, 2024
View reviewed changes
Comment thread Modules/_interpretersmodule.c Outdated
@ZeroIntensity @sobolevn
Update _interpretersmodule.c
4443bbc 
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
sobolevn approved these changes Oct 31, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

picnixz
picnixz reviewed Oct 31, 2024
View reviewed changes
Comment thread Lib/test/test_interpreters/test_api.py Outdated
Comment thread Misc/NEWS.d/next/Library/2024-10-30-23-42-44.gh-issue-126223.k2qooc.rst Outdated
Comment thread Modules/_interpretersmodule.c Outdated
Comment thread Lib/test/test_interpreters/test_api.py Outdated
ZeroIntensity and others added 5 commits October 31, 2024 08:18
@ZeroIntensity @picnixz
Update test_api.py
b937fc7 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@ZeroIntensity @picnixz
Update test_api.py
be4e5eb 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@ZeroIntensity @picnixz
Update _interpretersmodule.c
61c24e4 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@ZeroIntensity @picnixz
Update 2024-10-30-23-42-44.gh-issue-126223.k2qooc.rst
2ac7f6b 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@ZeroIntensity
Fix lint.
9ff672f
@picnixz picnixz self-requested a review October 31, 2024 13:48
sobolevn
sobolevn approved these changes Oct 31, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@sobolevn sobolevn merged commit 0141521 into python:main Oct 31, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 31, 2024

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2024
@ZeroIntensity @sobolevn
@picnixz @miss-islington
pythongh-126223: Propagate unicode errors in _interpreters.create() (…
0fe1118 
…pythonGH-126224)

(cherry picked from commit 0141521)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Oct 31, 2024

Copy link
Copy Markdown

GH-126242 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 31, 2024
@sobolevn

sobolevn commented Oct 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We got a Halloween easter egg, congrats 🎉
Снимок экрана 2024-10-31 в 17 14 51

@ZeroIntensity ZeroIntensity deleted the gh-126223 branch October 31, 2024 14:15
sobolevn added a commit that referenced this pull request Oct 31, 2024
@miss-islington @ZeroIntensity
@sobolevn @picnixz
[3.13] gh-126223: Propagate unicode errors in _interpreters.create() (
89664d4 
GH-126224) (#126242)

gh-126223: Propagate unicode errors in `_interpreters.create()` (GH-126224)
(cherry picked from commit 0141521)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@ZeroIntensity @sobolevn @picnixz
pythongh-126223: Propagate unicode errors in _interpreters.create() (…
a9e246e 
…python#126224)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@ZeroIntensity @sobolevn
@picnixz @ebonnal
pythongh-126223: Propagate unicode errors in _interpreters.create() (…
e12a733 
…python#126224)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

@picnixz picnixz picnixz approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity @sobolevn @picnixz