Skip to content

gh-126357: Remove gettext import guards#126358

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
tomasr8:gettext-import
Nov 3, 2024
Merged

gh-126357: Remove gettext import guards#126358
serhiy-storchaka merged 1 commit into
python:mainfrom
tomasr8:gettext-import

Conversation

@tomasr8

@tomasr8 tomasr8 commented Nov 3, 2024

Copy link
Copy Markdown
Member

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 75bae45 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 3, 2024

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this affect other implementations like PyPy?

@tomasr8

tomasr8 commented Nov 3, 2024

Copy link
Copy Markdown
Member Author

I don't know enough about PyPy to be able to answer that :/ Do you know how I could verify that?

@sobolevn

sobolevn commented Nov 3, 2024

Copy link
Copy Markdown
Member

You can take a look at the source code (https://github.com/pypy/pypy prefered way) or ping one of PyPy maintainers :)

I suspect that it won't, but just to be sure.

@tomasr8

tomasr8 commented Nov 3, 2024

Copy link
Copy Markdown
Member Author

Ok so I applied this patch to the vendored stdlib in PyPy and built pypy3.11 without any issues. Importing these modules at runtime does not cause any issues either so I think it should be fine.

The 4 buildbot failures also seem unrelated to this change.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then! Thanks for checking!

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka

Copy link
Copy Markdown
Member

I think that if there are some bootstrapping issues with the gettext module, they most likely should be solved in the gettext module. If there are some issues.

@serhiy-storchaka serhiy-storchaka merged commit ac556a2 into python:main Nov 3, 2024
@tomasr8 tomasr8 deleted the gettext-import branch November 3, 2024 19:22
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants