gh-127196: Fix crash in _interpreters, when shared had invalid encodings#127220
Merged
Conversation
…lid encodings
ZeroIntensity
approved these changes
Nov 24, 2024
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
Yup, this was the fix I was thinking of. LGTM.
vstinner
approved these changes
Nov 26, 2024
vstinner
left a comment
Member
There was a problem hiding this comment.
_run_in_interpreter() fix LGTM, and tests cover the modified code path.
Member
Author
|
Thank you! I will wait for @ericsnowcurrently's review, because this is an important part of the project. |
ericsnowcurrently
approved these changes
Jan 9, 2025
ericsnowcurrently
left a comment
Member
There was a problem hiding this comment.
LGTM
Sorry for the long delay!
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 9, 2025
…lid encodings (pythonGH-127220) (cherry picked from commit 087bb48) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-128689 is a backport of this pull request to the 3.13 branch. |
sobolevn
added a commit
that referenced
this pull request
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_interpreters.execwith invalid dict assharedsegfaults #127196