Skip to content

gh-129231: group executable JIT code in memory#129232

Merged
brandtbucher merged 3 commits into
python:mainfrom
diegorusso:jit-layout
Feb 2, 2025
Merged

gh-129231: group executable JIT code in memory#129232
brandtbucher merged 3 commits into
python:mainfrom
diegorusso:jit-layout

Conversation

@diegorusso

@diegorusso diegorusso commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

@diegorusso

diegorusso commented Jan 23, 2025

Copy link
Copy Markdown
Contributor Author

The change is not really tested as we need the -fplt flag on AArch64. Without this flag, clang-19 doesn't make use of the trampolines.
This is the branch that makes use of the fplt on AArch64 Linux: https://github.com/diegorusso/cpython/tree/fplt

We really need to get those changes first and then re-test this PR.

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I appreciate that you reordered things to reflect the new layout. But I don't think the reordering makes as much sense in the StencilGroup struct, so can you leave that the way it was?

Comment thread Tools/jit/_stencils.py Outdated
Comment thread Tools/jit/_writer.py
@brandtbucher brandtbucher merged commit a29a9c0 into python:main Feb 2, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@diegorusso diegorusso deleted the jit-layout branch April 4, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants