Skip to content

gh-132527: Added missing w typecode to array() error message#132529

Merged
hugovk merged 5 commits into
python:mainfrom
ChVeen:add-missing-w-typecode
Apr 25, 2025
Merged

gh-132527: Added missing w typecode to array() error message#132529
hugovk merged 5 commits into
python:mainfrom
ChVeen:add-missing-w-typecode

Conversation

@ChVeen

@ChVeen ChVeen commented Apr 14, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This PR fixes the missing w in the error message as obtained by array('x').
It solves issue: #132527

@python-cla-bot

python-cla-bot Bot commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Apr 14, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Apr 14, 2025
Closed
StanFromIreland
StanFromIreland reviewed Apr 14, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get a NEWS entry (click the link in the bot's comment for an easy way to do it) and you need to sign the CLA. I also recommend reading over the devguide.

Comment thread Modules/arraymodule.c
@ChVeen

ChVeen commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

This should get a NEWS entry (click the link in the bot's comment for an easy way to do it) and you need to sign the CLA. I also recommend reading over the devguide.

Done, thanx for your hint :-)

tomasr8
tomasr8 reviewed Apr 14, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-04-14-23-00-00.gh-issue-132527.kTi8T7.rst Outdated
terryjreedy
terryjreedy reviewed Apr 15, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-04-14-23-00-00.gh-issue-132527.kTi8T7.rst Outdated
@ChVeen @terryjreedy
update NEWS entry
6195a40 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
StanFromIreland
StanFromIreland approved these changes Apr 15, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@StanFromIreland StanFromIreland mentioned this pull request Apr 16, 2025
Closed
@ChVeen ChVeen requested a review from terryjreedy April 17, 2025 20:12
@ChVeen

This comment was marked as resolved.

Sign in to view
@tomasr8

This comment was marked as resolved.

Sign in to view
@StanFromIreland

This comment was marked as resolved.

Sign in to view
@ChVeen ChVeen marked this pull request as draft April 22, 2025 09:32
@ChVeen ChVeen marked this pull request as ready for review April 22, 2025 09:33
@ChVeen

This comment was marked as resolved.

Sign in to view
@StanFromIreland

This comment was marked as resolved.

Sign in to view
@ChVeen ChVeen closed this Apr 22, 2025
@ChVeen ChVeen reopened this Apr 22, 2025
@ChVeen

This comment was marked as resolved.

Sign in to view
@StanFromIreland

This comment was marked as resolved.

Sign in to view
@ChVeen

This comment was marked as resolved.

Sign in to view
@ambv

ambv commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

If I press this CLA label, I come again to the place where I signed it and it is still signed.

@ChVeen, it is signed for your private @gmail.com address but not for the public @github.com no-reply address:

image

You need to sign for the noreply address, too.

@ChVeen

ChVeen commented Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

If I press this CLA label, I come again to the place where I signed it and it is still signed.

@ChVeen, it is signed for your private @gmail.com address but not for the public @github.com no-reply address:

image

You need to sign for the noreply address, too.

Hi @ambv,
I checked this and it seems I can only choose my private e-mail address from the combobox.
But after choosing this a second time, suddenly a CLA for my public GitHub no-reply address was added as well.
Thanx for your help :-)

@hugovk hugovk merged commit 52454c5 into python:main Apr 25, 2025
@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 25, 2025

Copy link
Copy Markdown

Thanks @ChVeen for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2025
@ChVeen @terryjreedy
@tomasr8 @miss-islington
pythongh-132527: Added missing w typecode to array() error message (p…
ebc8655 
…ythonGH-132529)

(cherry picked from commit 52454c5)

Co-authored-by: Christian Veenhuis <124370897+ChVeen@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app

bedevere-app Bot commented Apr 25, 2025

Copy link
Copy Markdown

GH-132938 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
hugovk pushed a commit that referenced this pull request Apr 25, 2025
@miss-islington @ChVeen
@terryjreedy @tomasr8
[3.13] gh-132527: Added missing w typecode to array() error message (…
3ff35ba 
…GH-132529) (#132938)

Co-authored-by: Christian Veenhuis <124370897+ChVeen@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ChVeen @tomasr8 @StanFromIreland @ambv @terryjreedy @hugovk