Skip to content

gh-127604: Allow faulthandler to dumpC stack on MacOS#132841

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-127604
Apr 23, 2025
Merged

gh-127604: Allow faulthandler to dumpC stack on MacOS#132841
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-127604

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 23, 2025

Copy link
Copy Markdown
Member

@pablogsal

pablogsal commented Apr 23, 2025

Copy link
Copy Markdown
Member Author
❯ ./python.exe -m test test_faulthandler -v | grep c_stack
test_dump_c_stack (test.test_faulthandler.FaultHandlerTests.test_dump_c_stack) ... ok
test_dump_c_stack_file (test.test_faulthandler.FaultHandlerTests.test_dump_c_stack_file) ... ok

~/github/python/main gh-127604* 17s
❯ uname -a
Darwin HWJ59XLTF9 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:33:47 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T6000 arm64

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Mac to test this on, so I'll trust that you've tested this locally. The tests only require that it either spits out <cannot get backtrace> or the actual C backtrace.

Comment thread Python/traceback.c Outdated
Comment thread Python/traceback.c Outdated
@pablogsal

pablogsal commented Apr 23, 2025

Copy link
Copy Markdown
Member Author

I don't have a Mac to test this on, so I'll trust that you've tested this locally. The tests only require that it either spits out <cannot get backtrace> or the actual C backtrace.

My previous comment was proving exactly that :)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@pablogsal pablogsal merged commit 1007aab into python:main Apr 23, 2025
@pablogsal pablogsal deleted the gh-127604 branch April 23, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants