Skip to content

bpo-37165: Convert _count_elements to the argument clinic#13848

Merged
rhettinger merged 3 commits into
python:masterfrom
rhettinger:count_elements_clinic
Jun 5, 2019
Merged

bpo-37165: Convert _count_elements to the argument clinic#13848
rhettinger merged 3 commits into
python:masterfrom
rhettinger:count_elements_clinic

Conversation

@rhettinger

@rhettinger rhettinger commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this :)

I left some comments regarding a couple of missing things.

Comment thread Modules/_collectionsmodule.c
Comment thread Modules/_collectionsmodule.c

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

Copy link
Copy Markdown

GH-13853 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 5, 2019
(cherry picked from commit e985804)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@serhiy-storchaka

Copy link
Copy Markdown
Member

Usually we do not add a NEWS entry when convert a module or separate functions to Argument Clinic, as such conversion does not change the behavior. In this particular case the converted function is private, so there is even less reasons to add a NEWS entry.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance or resource usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants