Skip to content

[3.8] bpo-37261: Fix support.catch_unraisable_exception() (GH-14052)#14056

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-6d22cc8-3.8
Jun 13, 2019
Merged

[3.8] bpo-37261: Fix support.catch_unraisable_exception() (GH-14052)#14056
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-6d22cc8-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

The exit() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
(cherry picked from commit 6d22cc8)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37261

The __exit__() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
(cherry picked from commit 6d22cc8)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b4f5b21 into python:3.8 Jun 13, 2019
@miss-islington

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington deleted the backport-6d22cc8-3.8 branch June 13, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants