Skip to content

gh-120057: add os.reload_environ to __all__#140763

Merged
AlexWaygood merged 4 commits into
python:mainfrom
guoci:append_os_reload_environ_to_dunder_all
Oct 29, 2025
Merged

gh-120057: add os.reload_environ to __all__#140763
AlexWaygood merged 4 commits into
python:mainfrom
guoci:append_os_reload_environ_to_dunder_all

Conversation

@guoci

@guoci guoci commented Oct 29, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@StanFromIreland

StanFromIreland commented Oct 29, 2025

Copy link
Copy Markdown
Member

This should have a NEWS entry IMO.

@AlexWaygood AlexWaygood changed the title add os.reload_environ to __all__ gh-120057: add os.reload_environ to __all__ Oct 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 29, 2025
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.14 bugs and security fixes label Oct 29, 2025
AlexWaygood
AlexWaygood reviewed Oct 29, 2025
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I agree this should have a NEWS entry.

Cc. @vstinner as author of #126268.

We could consider adding a test for the os module like this one for inspect, to make sure that __all__ is kept up-to-date in the future:

cpython/Lib/test/test_inspect/test_inspect.py

Lines 125 to 126 in 8706167

def test__all__(self):
support.check__all__(self, inspect, not_exported=("modulesbyfile",), extra=("get_annotations",))

But that can be done as a standalone change; it doesn't need to be done here IMO

@AlexWaygood AlexWaygood self-assigned this Oct 29, 2025
StanFromIreland
StanFromIreland reviewed Oct 29, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-10-29-16-12-41.gh-issue-None.qGj5Dl.rst Outdated
@guoci @StanFromIreland
Fix Misc/NEWS.d/next/Library/2025-10-29-16-12-41.gh-issue-None.qGj5Dl…
85a44c7 
….rst

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
AlexWaygood
AlexWaygood approved these changes Oct 29, 2025
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@AlexWaygood AlexWaygood force-pushed the append_os_reload_environ_to_dunder_all branch from 53efc2a to 40331e6 Compare October 29, 2025 16:21
@AlexWaygood AlexWaygood enabled auto-merge (squash) October 29, 2025 16:21
@StanFromIreland

StanFromIreland commented Oct 29, 2025

Copy link
Copy Markdown
Member

CI failure is unrelated, I will rerun when possible.

vstinner
vstinner approved these changes Oct 29, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Well spotted, I forgot about __all__ when I added the function.

@AlexWaygood

AlexWaygood commented Oct 29, 2025

Copy link
Copy Markdown
Member

ARM workers are currently down across all GitHub, which apparently means that no CPython PRs can currently be merged https://www.githubstatus.com/

@vstinner

vstinner commented Oct 29, 2025

Copy link
Copy Markdown
Member

I reran the failing ARM jobs. Let's see if GHA feels better yet or not.

@AlexWaygood AlexWaygood merged commit b85e10f into python:main Oct 29, 2025
261 of 280 checks passed
@miss-islington-app

miss-islington-app Bot commented Oct 29, 2025

Copy link
Copy Markdown

Thanks @guoci for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2025
@guoci @StanFromIreland
@AlexWaygood @miss-islington
pythongh-120057: add os.reload_environ to __all__ (pythonGH-140763)
37027ce 
(cherry picked from commit b85e10f)

Co-authored-by: Guo Ci <zguoci@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app

bedevere-app Bot commented Oct 29, 2025

Copy link
Copy Markdown

GH-140773 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 29, 2025
AlexWaygood added a commit that referenced this pull request Oct 29, 2025
@miss-islington @guoci
@StanFromIreland @AlexWaygood
[3.14] gh-120057: add os.reload_environ to __all__ (GH-140763) (#…
6e70c75 
…140773)

Co-authored-by: Guo Ci <zguoci@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@guoci @StanFromIreland @AlexWaygood
pythongh-120057: add os.reload_environ to __all__ (python#140763)
2525c6c 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@vstinner vstinner vstinner approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guoci @StanFromIreland @AlexWaygood @vstinner