gh-143517: Fix an edge case in rewriting stringified starred annotations#143518
Merged
JelleZijlstra merged 3 commits intoJan 8, 2026
Merged
Conversation
Member
Author
|
(Ignore the name of 856f612, it's misleading) |
*
JelleZijlstra
approved these changes
Jan 8, 2026
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Not sure why anyone would do this, but we accept x: " int" and parse it into int, so I guess we should accept this too.
|
Thanks @johnslavik for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2026
…notations (pythonGH-143518) (cherry picked from commit 6c9f7b4) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
GH-143540 is a backport of this pull request to the 3.14 branch. |
Member
Author
I was mainly thinking that some automated code generation only could run into that. |
JelleZijlstra
pushed a commit
that referenced
this pull request
Jan 8, 2026
reidenong
pushed a commit
to reidenong/cpython
that referenced
this pull request
Jan 12, 2026
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_annotations(..., eval_str=True)throwsSyntaxErrorif stringified starred annotation starts with one or more spaces #143517