bpo-32894: Support unparsing of infinity numbers in ast_unparser.c by isidentical · Pull Request #17426 · python/cpython

isidentical · 2019-12-01T18:38:25Z

https://bugs.python.org/issue32894

bedevere-bot · 2019-12-01T19:03:41Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

isidentical · 2019-12-01T20:09:45Z

I have made the requested changes; please review again

bedevere-bot · 2019-12-01T20:09:47Z

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

bedevere-bot · 2019-12-02T22:13:55Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

isidentical · 2019-12-03T04:21:34Z

I have made the requested changes; please review again

bedevere-bot · 2019-12-03T04:21:38Z

Thanks for making the requested changes!

@pablogsal, @serhiy-storchaka: please review the changes made to this pull request.

vstinner

The PR is almost good. Just two last minor remarks. I'm not sure why interning was used in the first place. Does someone recall the rationale for interning strings?

isidentical · 2020-04-12T17:49:47Z

@vstinner @serhiy-storchaka can I get a re-review (or possibly a merge) for this. This is blocking me on another bugfix related C unparser.

vstinner

LGTM.

@isidentical

@isidentical addressed Serhiy's review.

vstinner · 2020-04-13T22:51:41Z

Merged, thanks @isidentical!

isidentical · 2020-04-13T22:52:15Z

Thank you for merge @vstinner.

the-knights-who-say-ni added the CLA signed label Dec 1, 2019

bedevere-bot added the awaiting review label Dec 1, 2019

serhiy-storchaka previously requested changes Dec 1, 2019

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

bedevere-bot added awaiting changes and removed awaiting review labels Dec 1, 2019

isidentical force-pushed the bpo-32894 branch from c18dce3 to 8e72b5e Compare December 1, 2019 20:03

bedevere-bot removed the awaiting changes label Dec 1, 2019

bedevere-bot added the awaiting change review label Dec 1, 2019

bedevere-bot requested a review from serhiy-storchaka December 1, 2019 20:09

serhiy-storchaka reviewed Dec 1, 2019

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

isidentical force-pushed the bpo-32894 branch from 087ce16 to dd4bb00 Compare December 2, 2019 14:18

isidentical requested a review from serhiy-storchaka December 2, 2019 14:50

pablogsal requested changes Dec 2, 2019

View reviewed changes

Comment thread Lib/test/test_future.py Outdated

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

bedevere-bot removed the awaiting change review label Dec 2, 2019

bedevere-bot added the awaiting changes label Dec 2, 2019

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 3, 2019

bedevere-bot requested a review from pablogsal December 3, 2019 04:21

isidentical force-pushed the bpo-32894 branch 2 times, most recently from 3c9c439 to 3ed11d3 Compare December 3, 2019 14:49

vstinner reviewed Dec 14, 2019

View reviewed changes

Comment thread Lib/test/test_future.py Outdated

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

vstinner reviewed Dec 17, 2019

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

vstinner reviewed Dec 17, 2019

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

isidentical force-pushed the bpo-32894 branch from 579ce34 to 15f1cbb Compare December 17, 2019 12:11

vstinner reviewed Jan 13, 2020

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

vstinner reviewed Jan 13, 2020

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

Comment thread Python/ast_unparse.c Outdated

vstinner reviewed Jan 13, 2020

View reviewed changes

Comment thread Python/ast_unparse.c Outdated

isidentical added 11 commits March 22, 2020 10:28

bpo-32894: Support unparsing of infinity numbers in ast_unparser.c

02ce988

apply suggestions

b99e288

test minus inf

483a44e

explicitly decrease reference count of original repr

bff7363

handle refleak, remove unnecesary return parameter

2236e57

use PyTuple_GET_SIZE

3a524f6

use static string initalization, fast path for float

73f3ed8

inline replace

5216c3f

fastpath for floats

c7749ba

dont intern strings

5230637

revert fast path for negative value support

0368257

isidentical force-pushed the bpo-32894 branch from f3b48d9 to 7d32b31 Compare March 22, 2020 07:41

isidentical force-pushed the bpo-32894 branch 2 times, most recently from c719152 to eeb8328 Compare March 31, 2020 17:55

support nested tuples

14e6fd3

isidentical force-pushed the bpo-32894 branch from eeb8328 to 14e6fd3 Compare March 31, 2020 18:19

vstinner approved these changes Apr 13, 2020

View reviewed changes

vstinner merged commit 258f517 into python:master Apr 13, 2020

bedevere-bot removed the awaiting merge label Apr 13, 2020

Uh oh!

Conversation

isidentical commented Dec 1, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Dec 1, 2019

Uh oh!

isidentical commented Dec 1, 2019

Uh oh!

bedevere-bot commented Dec 1, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Dec 2, 2019

Uh oh!

isidentical commented Dec 3, 2019

Uh oh!

bedevere-bot commented Dec 3, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isidentical commented Apr 12, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Apr 13, 2020

Uh oh!

isidentical commented Apr 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

isidentical commented Dec 1, 2019 •

edited by bedevere-bot

Loading