Skip to content

bpo-40334: regenerate metaparser as part of regen-all#19854

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-40334-regen-metagrammar
May 2, 2020
Merged

bpo-40334: regenerate metaparser as part of regen-all#19854
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-40334-regen-metagrammar

Conversation

@pablogsal

@pablogsal pablogsal commented May 2, 2020

Copy link
Copy Markdown
Member

This PR does the following:

  • Moves the regen-pegen target to the end of the regen-all so the changes in regen-token and are correctly picked up.
  • Adds a new target regen-pegen-metaparser that regenerates the metaparser (this means also that the CI will check that this file is updated from now on)
  • Adds regen-pegen-metaparser to regen-all

https://bugs.python.org/issue40334

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What brought about the desire to automatically regenerate the meta-parser?

@pablogsal

Copy link
Copy Markdown
Member Author

What brought about the desire to automatically regenerate the meta-parser?

Consistency with how we handle the rest of autogenerated files to know that they are up to date, more than anything.

@gvanrossum

gvanrossum commented May 2, 2020 via email

Copy link
Copy Markdown
Member

@pablogsal pablogsal merged commit d2baff4 into python:master May 2, 2020
@pablogsal pablogsal deleted the bpo-40334-regen-metagrammar branch May 2, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants