bpo-40637: Add option to disable builtin hashes#20121
Merged
Merged
Conversation
gpshead
reviewed
May 15, 2020
gpshead
left a comment
Member
There was a problem hiding this comment.
Overall, good. This saves compile time for distro packages. one nit on the flag name.
Signed-off-by: Christian Heimes <christian@python.org>
Member
Author
|
Thanks! I forgot to update the news entry. |
gpshead
approved these changes
May 15, 2020
Contributor
|
@tiran: Status check is done, and it's a success ✅ . |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
@tiran: Status check is done, and it's a failure ❌ . |
Contributor
|
@tiran: Status check is done, and it's a success ✅ . |
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
Signed-off-by: Christian Heimes <christian@python.org> Automerge-Triggered-By: @tiran
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue40637
Automerge-Triggered-By: @tiran