bpo-34666: Implement stream.awrite() and stream.aclose()#9274
Merged
Conversation
Contributor
Author
|
@willingc please review documentation changes. |
willingc
reviewed
Sep 13, 2018
willingc
left a comment
Contributor
There was a problem hiding this comment.
Looks great. A few tiny typos.
|
|
||
| Write *data* to the stream. | ||
|
|
||
| The method doesn't apply control-flow, the call should be |
Contributor
There was a problem hiding this comment.
This method doesn't apply control-flow. The call should be followed by...
|
|
||
| Write a list (or any iterable) of bytes to the stream. | ||
|
|
||
| The method doesn't apply control-flow, the call should be |
Contributor
There was a problem hiding this comment.
Same correction as above.
| @@ -0,0 +1,3 @@ | |||
| Implement ``asyncio.StreamWriter.awrite`` and | |||
| ``asyncio.StreamWriter.aclose()`` coroutines. Methods are needed for | |||
| providing consistent stream API with control flow switched on by default. | |||
willingc
approved these changes
Sep 13, 2018
Contributor
Author
|
@willingc thanks for the review! |
1st1
reviewed
Sep 14, 2018
| Close the write end of the stream after the buffered write | ||
| data is flushed. | ||
|
|
||
| .. attribute:: transport |
Member
There was a problem hiding this comment.
I actually moved these sections down on purpose...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34666