Skip to content

gh-99266: ctypes: Preserve a more detailed exception in _SimpleCData.from_param#99760

Merged
kumaraditya303 merged 15 commits into
python:mainfrom
kamilturek:gh-99266
Jan 21, 2023
Merged

gh-99266: ctypes: Preserve a more detailed exception in _SimpleCData.from_param#99760
kumaraditya303 merged 15 commits into
python:mainfrom
kamilturek:gh-99266

Conversation

@kamilturek

@kamilturek kamilturek commented Nov 24, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Closes #99266.

The exception from fd->setfunc is now saved and then restored if the object doesn't have an _as_parameter_.

@bedevere-bot bedevere-bot mentioned this pull request Nov 24, 2022
Closed
@kamilturek kamilturek force-pushed the gh-99266 branch 2 times, most recently from fba818d to 6d8d1ce Compare November 24, 2022 21:00
@AlexWaygood AlexWaygood changed the title gh-99266: Preserve a more detailed exception in from_param gh-99266: ctypes: Preserve a more detailed exception in _SimpleCData.from_param Nov 24, 2022
@kamilturek kamilturek marked this pull request as ready for review November 24, 2022 22:10
eric-wieser
eric-wieser approved these changes Dec 15, 2022
View reviewed changes

@eric-wieser eric-wieser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks!

kumaraditya303
kumaraditya303 requested changes Dec 24, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests, the doctests are not run by the buildbots.

@bedevere-bot

bedevere-bot commented Dec 24, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kamilturek

kamilturek commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 21, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

eric-wieser
eric-wieser reviewed Jan 21, 2023
View reviewed changes
Comment thread Modules/_ctypes/_ctypes.c
@kumaraditya303 kumaraditya303 added topic-ctypes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 21, 2023
@bedevere-bot

bedevere-bot commented Jan 21, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 924e7bf 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 21, 2023
kumaraditya303
kumaraditya303 approved these changes Jan 21, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kumaraditya303
kumaraditya303 reviewed Jan 21, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-11-24-21-52-31.gh-issue-99266.88GcV9.rst Outdated
@kamilturek

kamilturek commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the help and review! 🙂 That was a pleasure.

@kumaraditya303 kumaraditya303 merged commit b4e11a7 into python:main Jan 21, 2023
@kamilturek kamilturek deleted the gh-99266 branch January 21, 2023 13:49
@kamilturek kamilturek restored the gh-99266 branch January 21, 2023 13:49
@kamilturek kamilturek deleted the gh-99266 branch January 21, 2023 13:49
@kamilturek kamilturek restored the gh-99266 branch January 21, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

+1 more reviewer

@eric-wieser eric-wieser eric-wieser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-ctypes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ctypes: wrong exception message in docs

4 participants

@kamilturek @bedevere-bot @eric-wieser @kumaraditya303