Update documentation to use newer version of fresco - fixes #13345#13419
Update documentation to use newer version of fresco - fixes #13345#13419forki wants to merge 2 commits into
Conversation
|
As of 0.43.0 react native uses Fresco 1.0.1, could you change to that version? https://github.com/facebook/react-native/blob/0.43-stable/ReactAndroid/build.gradle#L280 |
|
@AndrewJack confirmed. it works. I updated the PR BUT: I think this will probably break again with future RN update ;-( |
|
@forki It probably will. Ideally the release notes would detail it as a breaking change. Always worth checking the versions that react native uses when upgrading. |
|
there is no way to bundle it automatically with the correct version? or make the upgrade tool fix it at least? |
|
Upgrade tool won't work in this case because the fresco addons are optional. The extra fresco dependencies weren't included in the react native library to reduce the app size for people who don't need the extra fresco features. |
|
Upgrade tool could be smart and to string replacement. But I assume release
notes will be good enough.
Am 10.04.2017 16:30 schrieb "Andrew Jack" <notifications@github.com>:
… Upgrade tool won't work in this case because the fresco addons are
optional.
The extra fresco dependencies weren't included in the react native library
to reduce the app size for people who don't need the extra fresco features.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13419 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNIq7-Rt1f6Kt3gfWWU7yXHsKgvRAks5ruj0PgaJpZM4M4xu3>
.
|
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Thanks for submitting a PR! Please read these instructions carefully: React Native crashes hard on fresco 0.11.0 - see react#13345 Repro case in react#13345 Closes react#13419 Differential Revision: D4913258 Pulled By: javache fbshipit-source-id: 8beb55102e0f2d362c77698a35ea7d57fdcba48d
Thanks for submitting a PR! Please read these instructions carefully:
Motivation (required)
React Native crashes hard on fresco 0.11.0 - see #13345
Test Plan (required)
Repro case in #13345