RCTNetworking does not require main thread setup#49475
Closed
sammy-SC wants to merge 4 commits into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69744400 |
…nc (#49440) Summary: changelog: [internal] move away from RCTUnsafeExecuteOnMainQueueSync in RCTSafeArea. Differential Revision: D69662510
…Sync and main thread setup (#49473) Summary: changelog: [internal] Add RCTTraitCollectionProxy which synchronises access to current trait collection. This way, RCTAppearance does not need main thread setup and RCTUnsafeExecuteOnMainQueueSync Differential Revision: D69750211
…9474) Summary: changelog: [internal] Can move setup to the background setup: 1. Use RCTTraitCollectionProxy to access current trait collection to check if force touch is available. 2. UIDevice.currentDevice is thread safe and can be read safely from a background thread. Differential Revision: D69744257
Summary: changelog: [internal] RCTNetworking does not need main thread setup, it doesn't access any main thread only resources. Differential Revision: D69744400
815a600 to
da6f834
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69744400 |
Collaborator
|
This pull request was successfully merged by @sammy-SC in 1705f96 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in 1705f96. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
RCTNetworking does not need main thread setup, it doesn't access any main thread only resources.
Differential Revision: D69744400