Skip to content

Translation of rendering-lists#321

Merged
arshadkazmi42 merged 2 commits into
reactjs:mainfrom
vishnupprajapat:transalation-of-rendering-lists
Jan 27, 2025
Merged

Translation of rendering-lists#321
arshadkazmi42 merged 2 commits into
reactjs:mainfrom
vishnupprajapat:transalation-of-rendering-lists

Conversation

@vishnupprajapat

@vishnupprajapat vishnupprajapat commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

New Hindi Translation Progress #168

@arshadkazmi42

Changes Proposed

Translation of rendering-lists

@vishnupprajapat

Copy link
Copy Markdown
Contributor Author

New Hindi Translation Progress #168
@arshadkazmi42

@arshadkazmi42

Copy link
Copy Markdown
Member

@vishnupprajapat Thank you for the PR. I will review it soon.

@arshadkazmi42 arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Overall looks good 👍

I have left a few minor comments, can you fix those? Once those are fixed we can merge the PR.

Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated
Comment thread src/content/learn/rendering-lists.md Outdated

@vishnupprajapat vishnupprajapat left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arshadkazmi42 I've fixed the minor comments you mentioned. Please review the changes

@arshadkazmi42 arshadkazmi42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Thank you for making all the changes.

@github-actions

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit 6f42e05 into reactjs:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants